Skip to content

feat: add C implementation for stats/base/dists/logistic/skewness #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2024
Merged

feat: add C implementation for stats/base/dists/logistic/skewness #4038

merged 3 commits into from
Dec 20, 2024

Conversation

@0PrashantYadav0
Copy link
Member

Resolves #3744

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/logistic/skewness along with relevant tests, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 18, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/logistic/skewness $\color{green}175/175$
$\color{green}+100.00\%$ 		$\color{green}9/9$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}175/175$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you very much @0PrashantYadav0!

Left a few comments, mainly related to indentation (make sure you have EditorConfig setup in your IDE), but otherwise PR should be ready to land.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 19, 2024
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 19, 2024
@0PrashantYadav0
Copy link
Member Author

@Planeshifter Please look into the pr. I make all the changes you asked for

Planeshifter
Planeshifter approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits, @0PrashantYadav0! Let's get this PR in.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 20, 2024
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Dec 20, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/logistic/skewness`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4038
Closes: https://github.com/stdlib-js/stdlib/issues/3744

Co-authored-by: JoyBoy <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6c141f4 into stdlib-js:develop Dec 20, 2024
29 checks passed
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@0PrashantYadav0 @ShabiShett07
feat: add C implementation for stats/base/dists/logistic/skewness
b7e9c8e 
PR-URL: stdlib-js#4038
Closes: stdlib-js#3744

Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/logistic/skewness

3 participants

@0PrashantYadav0 @stdlib-bot @Planeshifter